intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
+Saar for all things concepts.

On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <[hidden email]> wrote:
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
Has anyone tried to reproduce this yet?

Thanks,
Troy

From: Richard Smith <[hidden email]>
Sent: Tuesday, March 24, 2020 5:46 PM
To: Johnson, Troy <[hidden email]>; Saar Raz <[hidden email]>
Cc: [hidden email] <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
+Saar for all things concepts.

On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <[hidden email]> wrote:
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
Hey,
Didn't reproduce yet but I know how to fix the issue. That accessor can return null and there should be a null check there. 
I'll push a fix as soon as I can.
Thanks! 

On Fri, Apr 3, 2020, 10:23 PM Johnson, Troy <[hidden email]> wrote:
Has anyone tried to reproduce this yet?

Thanks,
Troy

From: Richard Smith <[hidden email]>
Sent: Tuesday, March 24, 2020 5:46 PM
To: Johnson, Troy <[hidden email]>; Saar Raz <[hidden email]>
Cc: [hidden email] <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
+Saar for all things concepts.

On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <[hidden email]> wrote:
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
The accessor can return null intermittently?  Why?

-Troy

From: Saar Raz <[hidden email]>
Sent: Friday, April 3, 2020 2:48 PM
To: Johnson, Troy <[hidden email]>
Cc: Richard Smith <[hidden email]>; Clang Dev <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
Hey,
Didn't reproduce yet but I know how to fix the issue. That accessor can return null and there should be a null check there. 
I'll push a fix as soon as I can.
Thanks! 

On Fri, Apr 3, 2020, 10:23 PM Johnson, Troy <[hidden email]> wrote:
Has anyone tried to reproduce this yet?

Thanks,
Troy

From: Richard Smith <[hidden email]>
Sent: Tuesday, March 24, 2020 5:46 PM
To: Johnson, Troy <[hidden email]>; Saar Raz <[hidden email]>
Cc: [hidden email] <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
+Saar for all things concepts.

On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <[hidden email]> wrote:
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp

Fangrui Song via cfe-dev
Hmm seems the code you posted is out of date,  8a3446746098ba29348bb8f85357dd0b466a6d6e (1.16.20) fixed this issue.

On Fri, Apr 3, 2020 at 10:55 PM Johnson, Troy <[hidden email]> wrote:
The accessor can return null intermittently?  Why?

-Troy

From: Saar Raz <[hidden email]>
Sent: Friday, April 3, 2020 2:48 PM
To: Johnson, Troy <[hidden email]>
Cc: Richard Smith <[hidden email]>; Clang Dev <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
Hey,
Didn't reproduce yet but I know how to fix the issue. That accessor can return null and there should be a null check there. 
I'll push a fix as soon as I can.
Thanks! 

On Fri, Apr 3, 2020, 10:23 PM Johnson, Troy <[hidden email]> wrote:
Has anyone tried to reproduce this yet?

Thanks,
Troy

From: Richard Smith <[hidden email]>
Sent: Tuesday, March 24, 2020 5:46 PM
To: Johnson, Troy <[hidden email]>; Saar Raz <[hidden email]>
Cc: [hidden email] <[hidden email]>
Subject: Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp
 
+Saar for all things concepts.

On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <[hidden email]> wrote:
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop.  It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:

void StmtProfiler::VisitConceptSpecializationExpr(
                                           const ConceptSpecializationExpr *S) {
  VisitExpr(S);
  VisitDecl(S->getFoundDecl());
  VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),
                         S->getTemplateArgsAsWritten()->NumTemplateArgs);
}

The S->getTemplateArgsAsWritten() call returns null.

I have not been able to determine why the behavior is intermittent.  Is there someone more familiar with this code who has an idea?

-Troy
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev