clang ToT doesn't build on macOS 10.10 anymore...?

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
Hi all,

I just tried updating my clang build on a few machines, and it built fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get this:

/Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias unsupported on this file format
AEABI_RTABI double __aeabi_dadd(double a, double b) COMPILER_RT_ALIAS(__adddf3);
                                                    ^
/Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
#define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias unsupported on this file format\")")
                                   ^
<scratch space>:89:6: note: expanded from here
 GCC error("alias unsupported on this file format")
     ^

Should this build?  Is 10.10 supported?

Thanks,

Sean


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
I just ran into the same thing :-/

On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
<[hidden email]> wrote:

> Hi all,
>
> I just tried updating my clang build on a few machines, and it built fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get this:
>
> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias unsupported on this file format
> AEABI_RTABI double __aeabi_dadd(double a, double b) COMPILER_RT_ALIAS(__adddf3);
>                                                     ^
> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias unsupported on this file format\")")
>                                    ^
> <scratch space>:89:6: note: expanded from here
>  GCC error("alias unsupported on this file format")
>      ^
>
> Should this build?  Is 10.10 supported?
>
> Thanks,
>
> Sean
>
>
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
CC'ing ahatanak and efriedma

So I bisected where building on macOS 10.10 broke, and found at least 2 commits that introduced errors:

-------------------------------
r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)

/llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:229:1: error: unknown type name 'DISPATCH_NOESCAPE'
DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
^
-------------------------------

-------------------------------
r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)

/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias unsupported on this file format
AEABI_RTABI double __aeabi_dadd(double a, double b) COMPILER_RT_ALIAS(__adddf3);
                                                    ^
-------------------------------


On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:

>I just ran into the same thing :-/
>
>On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
><[hidden email]> wrote:
>> Hi all,
>>
>> I just tried updating my clang build on a few machines, and it built
>fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get this:
>>
>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>28:53: error: alias unsupported on this file format
>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>COMPILER_RT_ALIAS(__adddf3);
>>                                                     ^
>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>unsupported on this file format\")")
>>                                    ^
>> <scratch space>:89:6: note: expanded from here
>>  GCC error("alias unsupported on this file format")
>>      ^
>>
>> Should this build?  Is 10.10 supported?


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
Wasn't the NOESCAPE error fixed in r321543?

https://reviews.llvm.org/D41601

On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]> wrote:
CC'ing ahatanak and efriedma

So I bisected where building on macOS 10.10 broke, and found at least 2 commits that introduced errors:

-------------------------------
r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)

/llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:229:1: error: unknown type name 'DISPATCH_NOESCAPE'
DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
^
-------------------------------

-------------------------------
r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)

/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias unsupported on this file format
AEABI_RTABI double __aeabi_dadd(double a, double b) COMPILER_RT_ALIAS(__adddf3);
                                                    ^
-------------------------------


On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:

>I just ran into the same thing :-/
>
>On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
><[hidden email]> wrote:
>> Hi all,
>>
>> I just tried updating my clang build on a few machines, and it built
>fine on 10.11, but on a macOS 10.10 with AppleClang <a href="tel:7.0.2.7000181" value="+17027000181">7.0.2.7000181 I get this:
>>
>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>28:53: error: alias unsupported on this file format
>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>COMPILER_RT_ALIAS(__adddf3);
>>                                                     ^
>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>unsupported on this file format\")")
>>                                    ^
>> <scratch space>:89:6: note: expanded from here
>>  GCC error("alias unsupported on this file format")
>>      ^
>>
>> Should this build?  Is 10.10 supported?




_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
Akira,

Yes, it seems so.  If I try to build r321543 I don't get the DISPATCH_NOESCAPE error, but do still get the adddf3.c error.

Sean


On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:

>Wasn't the NOESCAPE error fixed in r321543?
>
>https://reviews.llvm.org/D41601
>
>On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>wrote:
>
>> CC'ing ahatanak and efriedma
>>
>> So I bisected where building on macOS 10.10 broke, and found at least 2
>> commits that introduced errors:
>>
>> -------------------------------
>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>
>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:229:1:
>> error: unknown type name 'DISPATCH_NOESCAPE'
>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>> ^
>> -------------------------------
>>
>> -------------------------------
>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>
>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>> unsupported on this file format
>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>> COMPILER_RT_ALIAS(__adddf3);
>>                                                     ^
>> -------------------------------
>>
>>
>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>
>> >I just ran into the same thing :-/
>> >
>> >On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>> ><[hidden email]> wrote:
>> >> Hi all,
>> >>
>> >> I just tried updating my clang build on a few machines, and it built
>> >fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>> this:
>> >>
>> >> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>> >28:53: error: alias unsupported on this file format
>> >> AEABI_RTABI double __aeabi_dadd(double a, double b)
>> >COMPILER_RT_ALIAS(__adddf3);
>> >>                                                     ^
>> >> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>> >29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>> >> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>> >unsupported on this file format\")")
>> >>                                    ^
>> >> <scratch space>:89:6: note: expanded from here
>> >>  GCC error("alias unsupported on this file format")
>> >>      ^
>> >>
>> >> Should this build?  Is 10.10 supported?
>>


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
What target triple are you compiling for?  Targets which define
"__ARM_EABI__" should also define "__ELF__", as far as I know.

-Eli

On 3/12/2018 6:50 AM, Sean McBride wrote:

> Akira,
>
> Yes, it seems so.  If I try to build r321543 I don't get the DISPATCH_NOESCAPE error, but do still get the adddf3.c error.
>
> Sean
>
>
> On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:
>
>> Wasn't the NOESCAPE error fixed in r321543?
>>
>> https://reviews.llvm.org/D41601
>>
>> On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>> wrote:
>>
>>> CC'ing ahatanak and efriedma
>>>
>>> So I bisected where building on macOS 10.10 broke, and found at least 2
>>> commits that introduced errors:
>>>
>>> -------------------------------
>>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>>
>>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:229:1:
>>> error: unknown type name 'DISPATCH_NOESCAPE'
>>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>>> ^
>>> -------------------------------
>>>
>>> -------------------------------
>>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>>
>>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>>> unsupported on this file format
>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>> COMPILER_RT_ALIAS(__adddf3);
>>>                                                      ^
>>> -------------------------------
>>>
>>>
>>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>>
>>>> I just ran into the same thing :-/
>>>>
>>>> On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>>>> <[hidden email]> wrote:
>>>>> Hi all,
>>>>>
>>>>> I just tried updating my clang build on a few machines, and it built
>>>> fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>>> this:
>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>>>> 28:53: error: alias unsupported on this file format
>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>                                                      ^
>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>>>> 29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>>>>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>>>> unsupported on this file format\")")
>>>>>                                     ^
>>>>> <scratch space>:89:6: note: expanded from here
>>>>>   GCC error("alias unsupported on this file format")
>>>>>       ^
>>>>>
>>>>> Should this build?  Is 10.10 supported?
>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
Eli,

I don't believe I'm specifying any target triple (I confess I don't exactly know what that is).  I'm just doing a vanilla cmake & make on macOS 10.10 using Xcode 7.2.1's compiler & SDK.  No cross compiling.  Searching cmake's output for "triple" reveals this though: x86_64-apple-darwin14.5.0

One new data point: if I manually apply Akira's DISPATCH_NOESCAPE fix to r314850, that builds; but r314851 does not.

Sean


On Mon, 12 Mar 2018 12:22:25 -0700, Friedman, Eli said:

>What target triple are you compiling for?  Targets which define
>"__ARM_EABI__" should also define "__ELF__", as far as I know.
>
>-Eli
>
>On 3/12/2018 6:50 AM, Sean McBride wrote:
>> Akira,
>>
>> Yes, it seems so.  If I try to build r321543 I don't get the
>DISPATCH_NOESCAPE error, but do still get the adddf3.c error.
>>
>> Sean
>>
>>
>> On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:
>>
>>> Wasn't the NOESCAPE error fixed in r321543?
>>>
>>> https://reviews.llvm.org/D41601
>>>
>>> On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>>> wrote:
>>>
>>>> CC'ing ahatanak and efriedma
>>>>
>>>> So I bisected where building on macOS 10.10 broke, and found at least 2
>>>> commits that introduced errors:
>>>>
>>>> -------------------------------
>>>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>>>
>>>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:
>229:1:
>>>> error: unknown type name 'DISPATCH_NOESCAPE'
>>>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>>>> ^
>>>> -------------------------------
>>>>
>>>> -------------------------------
>>>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>>>
>>>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>>>> unsupported on this file format
>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>                                                      ^
>>>> -------------------------------
>>>>
>>>>
>>>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>>>
>>>>> I just ran into the same thing :-/
>>>>>
>>>>> On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>>>>> <[hidden email]> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I just tried updating my clang build on a few machines, and it built
>>>>> fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>>>> this:
>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>>>>> 28:53: error: alias unsupported on this file format
>>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>>                                                      ^
>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>>>>> 29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>>>>>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>>>>> unsupported on this file format\")")
>>>>>>                                     ^
>>>>>> <scratch space>:89:6: note: expanded from here
>>>>>>   GCC error("alias unsupported on this file format")
>>>>>>       ^
>>>>>>
>>>>>> Should this build?  Is 10.10 supported?
>>
>
>--
>Employee of Qualcomm Innovation Center, Inc.
>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
>Linux Foundation Collaborative Project
>

Cheers,

--
____________________________________________________________
Sean McBride, B. Eng                 [hidden email]
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
Can you get the exact command-line for the failing command?  (With make,
you should be able to get that with "make VERBOSE=1", I think.)

-Eli

On 3/14/2018 10:51 AM, Sean McBride wrote:

> Eli,
>
> I don't believe I'm specifying any target triple (I confess I don't exactly know what that is).  I'm just doing a vanilla cmake & make on macOS 10.10 using Xcode 7.2.1's compiler & SDK.  No cross compiling.  Searching cmake's output for "triple" reveals this though: x86_64-apple-darwin14.5.0
>
> One new data point: if I manually apply Akira's DISPATCH_NOESCAPE fix to r314850, that builds; but r314851 does not.
>
> Sean
>
>
> On Mon, 12 Mar 2018 12:22:25 -0700, Friedman, Eli said:
>
>> What target triple are you compiling for?  Targets which define
>> "__ARM_EABI__" should also define "__ELF__", as far as I know.
>>
>> -Eli
>>
>> On 3/12/2018 6:50 AM, Sean McBride wrote:
>>> Akira,
>>>
>>> Yes, it seems so.  If I try to build r321543 I don't get the
>> DISPATCH_NOESCAPE error, but do still get the adddf3.c error.
>>> Sean
>>>
>>>
>>> On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:
>>>
>>>> Wasn't the NOESCAPE error fixed in r321543?
>>>>
>>>> https://reviews.llvm.org/D41601
>>>>
>>>> On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>>>> wrote:
>>>>
>>>>> CC'ing ahatanak and efriedma
>>>>>
>>>>> So I bisected where building on macOS 10.10 broke, and found at least 2
>>>>> commits that introduced errors:
>>>>>
>>>>> -------------------------------
>>>>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:
>> 229:1:
>>>>> error: unknown type name 'DISPATCH_NOESCAPE'
>>>>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>>>>> ^
>>>>> -------------------------------
>>>>>
>>>>> -------------------------------
>>>>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>>>>> unsupported on this file format
>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>                                                       ^
>>>>> -------------------------------
>>>>>
>>>>>
>>>>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>>>>
>>>>>> I just ran into the same thing :-/
>>>>>>
>>>>>> On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>>>>>> <[hidden email]> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I just tried updating my clang build on a few machines, and it built
>>>>>> fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>>>>> this:
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>>>>>> 28:53: error: alias unsupported on this file format
>>>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>>>                                                       ^
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>>>>>> 29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>>>>>>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>>>>>> unsupported on this file format\")")
>>>>>>>                                      ^
>>>>>>> <scratch space>:89:6: note: expanded from here
>>>>>>>    GCC error("alias unsupported on this file format")
>>>>>>>        ^
>>>>>>>
>>>>>>> Should this build?  Is 10.10 supported?
>> --
>> Employee of Qualcomm Innovation Center, Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
>> Linux Foundation Collaborative Project
>>
> Cheers,
>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
(for ninja, pass -v to ninja)

On Wed, Mar 14, 2018, 7:35 PM Friedman, Eli via cfe-dev <[hidden email]> wrote:
Can you get the exact command-line for the failing command?  (With make,
you should be able to get that with "make VERBOSE=1", I think.)

-Eli

On 3/14/2018 10:51 AM, Sean McBride wrote:
> Eli,
>
> I don't believe I'm specifying any target triple (I confess I don't exactly know what that is).  I'm just doing a vanilla cmake & make on macOS 10.10 using Xcode 7.2.1's compiler & SDK.  No cross compiling.  Searching cmake's output for "triple" reveals this though: x86_64-apple-darwin14.5.0
>
> One new data point: if I manually apply Akira's DISPATCH_NOESCAPE fix to r314850, that builds; but r314851 does not.
>
> Sean
>
>
> On Mon, 12 Mar 2018 12:22:25 -0700, Friedman, Eli said:
>
>> What target triple are you compiling for?  Targets which define
>> "__ARM_EABI__" should also define "__ELF__", as far as I know.
>>
>> -Eli
>>
>> On 3/12/2018 6:50 AM, Sean McBride wrote:
>>> Akira,
>>>
>>> Yes, it seems so.  If I try to build r321543 I don't get the
>> DISPATCH_NOESCAPE error, but do still get the adddf3.c error.
>>> Sean
>>>
>>>
>>> On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:
>>>
>>>> Wasn't the NOESCAPE error fixed in r321543?
>>>>
>>>> https://reviews.llvm.org/D41601
>>>>
>>>> On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>>>> wrote:
>>>>
>>>>> CC'ing ahatanak and efriedma
>>>>>
>>>>> So I bisected where building on macOS 10.10 broke, and found at least 2
>>>>> commits that introduced errors:
>>>>>
>>>>> -------------------------------
>>>>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:
>> 229:1:
>>>>> error: unknown type name 'DISPATCH_NOESCAPE'
>>>>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>>>>> ^
>>>>> -------------------------------
>>>>>
>>>>> -------------------------------
>>>>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>>>>> unsupported on this file format
>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>                                                       ^
>>>>> -------------------------------
>>>>>
>>>>>
>>>>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>>>>
>>>>>> I just ran into the same thing :-/
>>>>>>
>>>>>> On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>>>>>> <[hidden email]> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I just tried updating my clang build on a few machines, and it built
>>>>>> fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>>>>> this:
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>>>>>> 28:53: error: alias unsupported on this file format
>>>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>>>                                                       ^
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>>>>>> 29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>>>>>>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>>>>>> unsupported on this file format\")")
>>>>>>>                                      ^
>>>>>>> <scratch space>:89:6: note: expanded from here
>>>>>>>    GCC error("alias unsupported on this file format")
>>>>>>>        ^
>>>>>>>
>>>>>>> Should this build?  Is 10.10 supported?
>> --
>> Employee of Qualcomm Innovation Center, Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
>> Linux Foundation Collaborative Project
>>
> Cheers,
>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
From off-list, got the compiler invocation.  It looks like it's invoking clang from Xcode, and that clang has a bug where it incorrectly defines __ARM_EABI__ for -arch armv7em.  (Not sure off the top of my head how old AppleClang 7 is.)

Should work if you build using a more recent version of clang.  Or maybe you can work around the problem by commenting out the call to darwin_add_embedded_builtin_libraries() in compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake .

-Eli

On 3/14/2018 1:24 PM, Nico Weber wrote:
(for ninja, pass -v to ninja)

On Wed, Mar 14, 2018, 7:35 PM Friedman, Eli via cfe-dev <[hidden email]> wrote:
Can you get the exact command-line for the failing command?  (With make,
you should be able to get that with "make VERBOSE=1", I think.)

-Eli

On 3/14/2018 10:51 AM, Sean McBride wrote:
> Eli,
>
> I don't believe I'm specifying any target triple (I confess I don't exactly know what that is).  I'm just doing a vanilla cmake & make on macOS 10.10 using Xcode 7.2.1's compiler & SDK.  No cross compiling.  Searching cmake's output for "triple" reveals this though: x86_64-apple-darwin14.5.0
>
> One new data point: if I manually apply Akira's DISPATCH_NOESCAPE fix to r314850, that builds; but r314851 does not.
>
> Sean
>
>
> On Mon, 12 Mar 2018 12:22:25 -0700, Friedman, Eli said:
>
>> What target triple are you compiling for?  Targets which define
>> "__ARM_EABI__" should also define "__ELF__", as far as I know.
>>
>> -Eli
>>
>> On 3/12/2018 6:50 AM, Sean McBride wrote:
>>> Akira,
>>>
>>> Yes, it seems so.  If I try to build r321543 I don't get the
>> DISPATCH_NOESCAPE error, but do still get the adddf3.c error.
>>> Sean
>>>
>>>
>>> On Sat, 10 Mar 2018 15:46:54 -0800, Akira Hatanaka said:
>>>
>>>> Wasn't the NOESCAPE error fixed in r321543?
>>>>
>>>> https://reviews.llvm.org/D41601
>>>>
>>>> On Sat, Mar 10, 2018 at 1:35 PM, Sean McBride <[hidden email]>
>>>> wrote:
>>>>
>>>>> CC'ing ahatanak and efriedma
>>>>>
>>>>> So I bisected where building on macOS 10.10 broke, and found at least 2
>>>>> commits that introduced errors:
>>>>>
>>>>> -------------------------------
>>>>> r313929 | ahatanak | 2017-09-21 18:16:50 -0400 (Thu, 21 Sep 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc:
>> 229:1:
>>>>> error: unknown type name 'DISPATCH_NOESCAPE'
>>>>> DISPATCH_INTERCEPT_SYNC_B(dispatch_sync, false)
>>>>> ^
>>>>> -------------------------------
>>>>>
>>>>> -------------------------------
>>>>> r314851 | efriedma | 2017-10-03 17:25:07 -0400 (Tue, 03 Oct 2017)
>>>>>
>>>>> /llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:28:53: error: alias
>>>>> unsupported on this file format
>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>                                                       ^
>>>>> -------------------------------
>>>>>
>>>>>
>>>>> On Wed, 7 Feb 2018 12:23:16 +0100, Hans Wennborg said:
>>>>>
>>>>>> I just ran into the same thing :-/
>>>>>>
>>>>>> On Fri, Jan 26, 2018 at 11:22 PM, Sean McBride via cfe-dev
>>>>>> <[hidden email]> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I just tried updating my clang build on a few machines, and it built
>>>>>> fine on 10.11, but on a macOS 10.10 with AppleClang 7.0.2.7000181 I get
>>>>> this:
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/adddf3.c:
>>>>>> 28:53: error: alias unsupported on this file format
>>>>>>> AEABI_RTABI double __aeabi_dadd(double a, double b)
>>>>>> COMPILER_RT_ALIAS(__adddf3);
>>>>>>>                                                       ^
>>>>>>> /Users/builder/llvm/llvm/projects/compiler-rt/lib/builtins/int_lib.h:
>>>>>> 29:36: note: expanded from macro 'COMPILER_RT_ALIAS'
>>>>>>> #define COMPILER_RT_ALIAS(aliasee) _Pragma("GCC error(\"alias
>>>>>> unsupported on this file format\")")
>>>>>>>                                      ^
>>>>>>> <scratch space>:89:6: note: expanded from here
>>>>>>>    GCC error("alias unsupported on this file format")
>>>>>>>        ^
>>>>>>>
>>>>>>> Should this build?  Is 10.10 supported?
>> --
>> Employee of Qualcomm Innovation Center, Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
>> Linux Foundation Collaborative Project
>>
> Cheers,
>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: clang ToT doesn't build on macOS 10.10 anymore...?

Hans Wennborg via cfe-dev
On Wed, 14 Mar 2018 15:39:05 -0700, Friedman, Eli said:

> From off-list, got the compiler invocation.  It looks like it's
>invoking clang from Xcode, and that clang has a bug where it incorrectly
>defines __ARM_EABI__ for -arch armv7em.  (Not sure off the top of my
>head how old AppleClang 7 is.)

Xcode 7.2.1 was released February 3, 2016.  Not so old.  It's the last/newest Xcode that supports running on OS X 10.10.

>Should work if you build using a more recent version of clang.

I suppose one could get a clang/gcc from "somewhere" to bootstap clang ToT.  But really my point is that using Xcode is the easiest way, and if the newest Xcode for that OS isn't supported, it's a much bigger pain. :(

>Or maybe
>you can work around the problem by commenting out the call to
>darwin_add_embedded_builtin_libraries() in
>compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake .

Confirmed.  I can build r314851 if I comment out that line.

Cheers,

Sean


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev