cfe-commits@ now automatically subscribed to Clang review requests

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

cfe-commits@ now automatically subscribed to Clang review requests

Robinson, Paul via cfe-dev
I landed D40494 today, which enables Herald rule H268 to automatically subscribe [hidden email] to any review requests sent out in the Clang repository.

Specifically, after syncing to SVN revision 319052 / git commit 64881a00, any review requests will automatically subscribe cfe-commits@ — you no longer have to remember to manually add this to each review request.

I also landed D40180, which does the same thing for clang-tools-extra. Once D40500 and D40501 land, they will also do this for libc++ and libc++abi reviews.

If you want to opt out of this feature, just add [private] to your revision title. (Note that review requests are still visible in Differential; this just disables copying cfe-commits@.)

Thanks,

Ben

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: cfe-commits@ now automatically subscribed to Clang review requests

Robinson, Paul via cfe-dev
Great!
This only works when submitting revisions via arc, right?

On Nov 27, 2017, at 11:00 AM, Ben Hamilton via cfe-dev <[hidden email]> wrote:

I landed D40494 today, which enables Herald rule H268 to automatically subscribe [hidden email] to any review requests sent out in the Clang repository.

Specifically, after syncing to SVN revision 319052 / git commit 64881a00, any review requests will automatically subscribe cfe-commits@ — you no longer have to remember to manually add this to each review request.

I also landed D40180, which does the same thing for clang-tools-extra. Once D40500 and D40501 land, they will also do this for libc++ and libc++abi reviews.

If you want to opt out of this feature, just add [private] to your revision title. (Note that review requests are still visible in Differential; this just disables copying cfe-commits@.)

Thanks,

Ben



_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: cfe-commits@ now automatically subscribed to Clang review requests

Robinson, Paul via cfe-dev
It should work both when submitting revisions via the arc command-line and via the Differential web interface.

I'm not aware of any other ways to send out review requests for Clang, but let me know if there are any I missed. :)

Ben

On Mon, Nov 27, 2017 at 12:19 PM George Karpenkov <[hidden email]> wrote:
Great!
This only works when submitting revisions via arc, right?


On Nov 27, 2017, at 11:00 AM, Ben Hamilton via cfe-dev <[hidden email]> wrote:

I landed D40494 today, which enables Herald rule H268 to automatically subscribe [hidden email] to any review requests sent out in the Clang repository.

Specifically, after syncing to SVN revision 319052 / git commit 64881a00, any review requests will automatically subscribe cfe-commits@ — you no longer have to remember to manually add this to each review request.

I also landed D40180, which does the same thing for clang-tools-extra. Once D40500 and D40501 land, they will also do this for libc++ and libc++abi reviews.

If you want to opt out of this feature, just add [private] to your revision title. (Note that review requests are still visible in Differential; this just disables copying cfe-commits@.)

Thanks,

Ben



_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev