analyzer issue

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

analyzer issue

Jordy Rose

Playing with this today, the issues discussed in PR7406 seem to stem from
two causes:

1. AttrNonNullChecker doesn't expect the value of a nonnull argument to be
unknown when it's checked. Patch here:
http://llvm.org/bugs/attachment.cgi?id=5067

2. The additive folding code in SimpleSValuator and the constraint manager
doesn't handle the case where the constants are of different types
(unsigned, long long, etc). Patch here:
http://llvm.org/bugs/attachment.cgi?id=5069

#2 in particular could use a review, since it's a nontrivial fix (a number
of type conversions). And of course it was me who didn't get this right the
first time around. Ted? Zhongxing?

Jordy
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: analyzer issue

Zhongxing Xu
Both patches look good to me.

On Mon, Jun 21, 2010 at 10:33 AM, Jordy Rose <[hidden email]> wrote:

Playing with this today, the issues discussed in PR7406 seem to stem from
two causes:

1. AttrNonNullChecker doesn't expect the value of a nonnull argument to be
unknown when it's checked. Patch here:
http://llvm.org/bugs/attachment.cgi?id=5067

2. The additive folding code in SimpleSValuator and the constraint manager
doesn't handle the case where the constants are of different types
(unsigned, long long, etc). Patch here:
http://llvm.org/bugs/attachment.cgi?id=5069

#2 in particular could use a review, since it's a nontrivial fix (a number
of type conversions). And of course it was me who didn't get this right the
first time around. Ted? Zhongxing?

Jordy
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: analyzer issue

Ted Kremenek
In reply to this post by Jordy Rose
Both of these patches look great.

On Jun 20, 2010, at 7:33 PM, Jordy Rose wrote:

>
> Playing with this today, the issues discussed in PR7406 seem to stem from
> two causes:
>
> 1. AttrNonNullChecker doesn't expect the value of a nonnull argument to be
> unknown when it's checked. Patch here:
> http://llvm.org/bugs/attachment.cgi?id=5067
>
> 2. The additive folding code in SimpleSValuator and the constraint manager
> doesn't handle the case where the constants are of different types
> (unsigned, long long, etc). Patch here:
> http://llvm.org/bugs/attachment.cgi?id=5069
>
> #2 in particular could use a review, since it's a nontrivial fix (a number
> of type conversions). And of course it was me who didn't get this right the
> first time around. Ted? Zhongxing?
>
> Jordy
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev