Using clang static analyser / clang-tidy for assignments grading?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Using clang static analyser / clang-tidy for assignments grading?

Fangrui Song via cfe-dev
Hi everyone!
I hope that I'm querying the correct mailing list about my question.

I work as a teaching assistant at the Hebrew University, teaching C and C++. As part of our course, we ask the students to submit C and C++ exercises which we grade (both manually and automatically).

When grading students exercises, we check the validity of their code. For example,
  • We check if the students didn't forget to use include safe-guard;
  • If the students used non-safe functions, which we consider forbidden to use (in addition, sometimes we explicitly tell students not to use set of predefined functions or C++ classes, as the exercises ask them to implement this set of functions).
  • If the students didn't include a forbidden header;
  • If the students didn't use a #pragma statement to bypass our compilation instructions;
  • C++: If the students remembered to use "const" when required, and to pass parameters by reference when needed;
  • C++: that the students returned lvalue when needed and rvalue when needed etc.
  • C++: When writing an iterator, if it was implemented correctly (a.k.a, according to Input/Output/Forward/Bidirectional/Random Access iterator rules + using iterator traits).
Right now these tests are being done by a human. As our classes formed from 300 to 600 students (next semester we'll have 650...) it'll be really hard and non-efficient to do it by hand. Thus I thought it might be a good idea to automate these checks too.

Initially, I thought to write that with Python using ANTLr (creating an AST for both the Preprocessing stage and the C stage and just iterating over them), but at the middle of programming, I came across the Static Analyser API of Clang and thought I should switch to it, as it seems very mature and well fit for our needs.

Before diving deeply into clang, I'd love to hear from you, who have experience in clang and LLVM dev, if I'm on the right track, and can actually achieve my goal using clang, or I should stick with my previous attempt. Our end goal is a program that we can run, send the path to the student exercise, and get the errors that she had so that we can reduce points accordingly. 

Thank you very much!
Yahav.

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Using clang static analyser / clang-tidy for assignments grading?

Fangrui Song via cfe-dev
Hi Yahav,

It is certainly possible using the static analyser and clang tidy frameworks to implement most of that checking. In clang tidy there are dedicated checks for some of the restrictions you need. Others would be vary easy to write AST matches or preprocessor callbacks for.

However it's my personal opinion that this should not be used as a replacement for a human grading but more as an assistant. When patches are submitted for review here we have automatic checks that check validity and can reject obvious flaws but it is always up to a reviewer to have a look over before a go ahead is given. 

If you do decide to go down the route of using clang to help out then definitely check out the code in the clang-tidy checks(static analyser not so much), have a look at the AST matches docs https://clang.llvm.org/docs/LibASTMatchersReference.html and have a play with clang-query. 

Kind regards, 
Nathan James. 


From: cfe-dev <[hidden email]> on behalf of Yahav Bar via cfe-dev <[hidden email]>
Sent: Friday, 28 February 2020, 16:29
To: [hidden email]
Subject: [cfe-dev] Using clang static analyser / clang-tidy for assignments grading?

Hi everyone!
I hope that I'm querying the correct mailing list about my question.

I work as a teaching assistant at the Hebrew University, teaching C and C++. As part of our course, we ask the students to submit C and C++ exercises which we grade (both manually and automatically).

When grading students exercises, we check the validity of their code. For example,
  • We check if the students didn't forget to use include safe-guard;
  • If the students used non-safe functions, which we consider forbidden to use (in addition, sometimes we explicitly tell students not to use set of predefined functions or C++ classes, as the exercises ask them to implement this set of functions).
  • If the students didn't include a forbidden header;
  • If the students didn't use a #pragma statement to bypass our compilation instructions;
  • C++: If the students remembered to use "const" when required, and to pass parameters by reference when needed;
  • C++: that the students returned lvalue when needed and rvalue when needed etc.
  • C++: When writing an iterator, if it was implemented correctly (a.k.a, according to Input/Output/Forward/Bidirectional/Random Access iterator rules + using iterator traits).
Right now these tests are being done by a human. As our classes formed from 300 to 600 students (next semester we'll have 650...) it'll be really hard and non-efficient to do it by hand. Thus I thought it might be a good idea to automate these checks too.

Initially, I thought to write that with Python using ANTLr (creating an AST for both the Preprocessing stage and the C stage and just iterating over them), but at the middle of programming, I came across the Static Analyser API of Clang and thought I should switch to it, as it seems very mature and well fit for our needs.

Before diving deeply into clang, I'd love to hear from you, who have experience in clang and LLVM dev, if I'm on the right track, and can actually achieve my goal using clang, or I should stick with my previous attempt. Our end goal is a program that we can run, send the path to the student exercise, and get the errors that she had so that we can reduce points accordingly. 

Thank you very much!
Yahav.


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Using clang static analyser / clang-tidy for assignments grading?

Fangrui Song via cfe-dev
Hi Nathan! How're you?
Thanks for your kind reply!

I started to dive into Clang and while it does require a learning curve, I think that it'll be perfect. 

About manual grading: we do have a manual grading process, but we do want to automate simple tasks as checking if a forbidden function was used, as it's really easy to miss it when grading an exercise. Of course, when the system will report on such things, we will check it manually as well, but the first check, ideally, be automatic.

My main wonder now is if I should write a clang-tidy library, or create an entirely new tool, from scratch, using Clang and Libtooling. I'd love to hear your thoughts: On the one hand, clang-tidy is very mature, got modules support and even contain some tests that we need. But on the other hand, I have a few concerns that I'm worried about:
  • We want to perform actions with the diagnostic results. For example, if a student used a public class variable, we want to reduce points on that. Our faculty has an internal file format that you can use to automatically reduce (or add) points from a student. So, we need some kind of a hook that allows us to get a report from "NonPrivateMemberVariablesInClassesCheck" so that we can write on that file at that point.
    As far as I understand, clang-tidy only allows us to print the diagnostics to the screen. Is there any way I can achieve that behaviour using clang-tidy?
  • clang-tidy allows disabling linting using "// NOLINT" comment. We want to disable this feature, so that students won't be able to cancel our checks. If I understand correctly, it can be done using CommentHandler but I want to make sure, as otherwise, we won't be able to use clang-tidy.
  • We want to perform an API comparison between the expected API definition (provided as JSON/YAML etc.) and the actual implementation API. Based on that, we want to write a new .h file that contains macro for every implemented function and feature. For example, if we asked the students to implement HashMap<K, V>::at(const K&), we will write on the output .h file a macro named HASHMAP_METHOD_AT if the method exists, and in addition, we will write on it HASHMAP_METHOD_AT_RETURN_LVALUE if the function returns an lvalue. We need that as we write some C++ tests to check the student's code, and we noticed that they sometimes mistake between lvalue and rvalue, so then our tests won't compile and everything falls for them. In addition, sometimes they even forget to implement some methods (for example, in the HashMap exercise we gave them, some forgot to implement the entire set of methods iterator requires) - and that killed the compilation process as well. 

    That's just a concept idea as I'm not sure how good it'll get implemented, but our end goal is to be able to write C++ tests that won't get compilation errors if the students didn't implement correctly the entire API.
So my question is, do you think that clang-tidy is suitable for such things? or I should write a new Clang and Libtooling based tool that can do that?
I really appreciate your time and efforts to help us!

Best regards,
Yahav.


On Sat, Feb 29, 2020 at 4:57 AM Nathan James <[hidden email]> wrote:
Hi Yahav,

It is certainly possible using the static analyser and clang tidy frameworks to implement most of that checking. In clang tidy there are dedicated checks for some of the restrictions you need. Others would be vary easy to write AST matches or preprocessor callbacks for.

However it's my personal opinion that this should not be used as a replacement for a human grading but more as an assistant. When patches are submitted for review here we have automatic checks that check validity and can reject obvious flaws but it is always up to a reviewer to have a look over before a go ahead is given. 

If you do decide to go down the route of using clang to help out then definitely check out the code in the clang-tidy checks(static analyser not so much), have a look at the AST matches docs https://clang.llvm.org/docs/LibASTMatchersReference.html and have a play with clang-query. 

Kind regards, 
Nathan James. 


From: cfe-dev <[hidden email]> on behalf of Yahav Bar via cfe-dev <[hidden email]>
Sent: Friday, 28 February 2020, 16:29
To: [hidden email]
Subject: [cfe-dev] Using clang static analyser / clang-tidy for assignments grading?

Hi everyone!
I hope that I'm querying the correct mailing list about my question.

I work as a teaching assistant at the Hebrew University, teaching C and C++. As part of our course, we ask the students to submit C and C++ exercises which we grade (both manually and automatically).

When grading students exercises, we check the validity of their code. For example,
  • We check if the students didn't forget to use include safe-guard;
  • If the students used non-safe functions, which we consider forbidden to use (in addition, sometimes we explicitly tell students not to use set of predefined functions or C++ classes, as the exercises ask them to implement this set of functions).
  • If the students didn't include a forbidden header;
  • If the students didn't use a #pragma statement to bypass our compilation instructions;
  • C++: If the students remembered to use "const" when required, and to pass parameters by reference when needed;
  • C++: that the students returned lvalue when needed and rvalue when needed etc.
  • C++: When writing an iterator, if it was implemented correctly (a.k.a, according to Input/Output/Forward/Bidirectional/Random Access iterator rules + using iterator traits).
Right now these tests are being done by a human. As our classes formed from 300 to 600 students (next semester we'll have 650...) it'll be really hard and non-efficient to do it by hand. Thus I thought it might be a good idea to automate these checks too.

Initially, I thought to write that with Python using ANTLr (creating an AST for both the Preprocessing stage and the C stage and just iterating over them), but at the middle of programming, I came across the Static Analyser API of Clang and thought I should switch to it, as it seems very mature and well fit for our needs.

Before diving deeply into clang, I'd love to hear from you, who have experience in clang and LLVM dev, if I'm on the right track, and can actually achieve my goal using clang, or I should stick with my previous attempt. Our end goal is a program that we can run, send the path to the student exercise, and get the errors that she had so that we can reduce points accordingly. 

Thank you very much!
Yahav.


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Using clang static analyser / clang-tidy for assignments grading?

Fangrui Song via cfe-dev
Hi Yahav, 


I would suggest using clang-tidy and it's checks as inspiration. However for the purposes of what you need it would be best to make a new libtooling tool that still registers matchers and callbacks but doesn't have all the boilerplate that clang tidy needs. This will make it easier to implement the hooks you need for altering a students grade as well as prevent things like `//NOLINT` comments.

As for the issue with compiler errors, that shouldn't be a huge problem as the AST will get generated even with small compiler errors that the compiler can infer the fix for.

I do have another suggestion if you want to speed up marking the submissions is a testing framework. Just a tool that will compile and run the students submissions with specified inputs and verify their code has the desired output, after all their is no point in pretty code bug produces bad outputs.

Regards,
Nathan James


From: Yahav Bar <[hidden email]>
Sent: Saturday, February 29, 2020 7:11:54 PM
To: Nathan James <[hidden email]>
Cc: [hidden email] <[hidden email]>
Subject: Re: [cfe-dev] Using clang static analyser / clang-tidy for assignments grading?
 
Hi Nathan! How're you?
Thanks for your kind reply!

I started to dive into Clang and while it does require a learning curve, I think that it'll be perfect. 

About manual grading: we do have a manual grading process, but we do want to automate simple tasks as checking if a forbidden function was used, as it's really easy to miss it when grading an exercise. Of course, when the system will report on such things, we will check it manually as well, but the first check, ideally, be automatic.

My main wonder now is if I should write a clang-tidy library, or create an entirely new tool, from scratch, using Clang and Libtooling. I'd love to hear your thoughts: On the one hand, clang-tidy is very mature, got modules support and even contain some tests that we need. But on the other hand, I have a few concerns that I'm worried about:
  • We want to perform actions with the diagnostic results. For example, if a student used a public class variable, we want to reduce points on that. Our faculty has an internal file format that you can use to automatically reduce (or add) points from a student. So, we need some kind of a hook that allows us to get a report from "NonPrivateMemberVariablesInClassesCheck" so that we can write on that file at that point.
    As far as I understand, clang-tidy only allows us to print the diagnostics to the screen. Is there any way I can achieve that behaviour using clang-tidy?
  • clang-tidy allows disabling linting using "// NOLINT" comment. We want to disable this feature, so that students won't be able to cancel our checks. If I understand correctly, it can be done using CommentHandler but I want to make sure, as otherwise, we won't be able to use clang-tidy.
  • We want to perform an API comparison between the expected API definition (provided as JSON/YAML etc.) and the actual implementation API. Based on that, we want to write a new .h file that contains macro for every implemented function and feature. For example, if we asked the students to implement HashMap<K, V>::at(const K&), we will write on the output .h file a macro named HASHMAP_METHOD_AT if the method exists, and in addition, we will write on it HASHMAP_METHOD_AT_RETURN_LVALUE if the function returns an lvalue. We need that as we write some C++ tests to check the student's code, and we noticed that they sometimes mistake between lvalue and rvalue, so then our tests won't compile and everything falls for them. In addition, sometimes they even forget to implement some methods (for example, in the HashMap exercise we gave them, some forgot to implement the entire set of methods iterator requires) - and that killed the compilation process as well. 

    That's just a concept idea as I'm not sure how good it'll get implemented, but our end goal is to be able to write C++ tests that won't get compilation errors if the students didn't implement correctly the entire API.
So my question is, do you think that clang-tidy is suitable for such things? or I should write a new Clang and Libtooling based tool that can do that?
I really appreciate your time and efforts to help us!

Best regards,
Yahav.


On Sat, Feb 29, 2020 at 4:57 AM Nathan James <[hidden email]> wrote:
Hi Yahav,

It is certainly possible using the static analyser and clang tidy frameworks to implement most of that checking. In clang tidy there are dedicated checks for some of the restrictions you need. Others would be vary easy to write AST matches or preprocessor callbacks for.

However it's my personal opinion that this should not be used as a replacement for a human grading but more as an assistant. When patches are submitted for review here we have automatic checks that check validity and can reject obvious flaws but it is always up to a reviewer to have a look over before a go ahead is given. 

If you do decide to go down the route of using clang to help out then definitely check out the code in the clang-tidy checks(static analyser not so much), have a look at the AST matches docs https://clang.llvm.org/docs/LibASTMatchersReference.html and have a play with clang-query. 

Kind regards, 
Nathan James. 


From: cfe-dev <[hidden email]> on behalf of Yahav Bar via cfe-dev <[hidden email]>
Sent: Friday, 28 February 2020, 16:29
To: [hidden email]
Subject: [cfe-dev] Using clang static analyser / clang-tidy for assignments grading?

Hi everyone!
I hope that I'm querying the correct mailing list about my question.

I work as a teaching assistant at the Hebrew University, teaching C and C++. As part of our course, we ask the students to submit C and C++ exercises which we grade (both manually and automatically).

When grading students exercises, we check the validity of their code. For example,
  • We check if the students didn't forget to use include safe-guard;
  • If the students used non-safe functions, which we consider forbidden to use (in addition, sometimes we explicitly tell students not to use set of predefined functions or C++ classes, as the exercises ask them to implement this set of functions).
  • If the students didn't include a forbidden header;
  • If the students didn't use a #pragma statement to bypass our compilation instructions;
  • C++: If the students remembered to use "const" when required, and to pass parameters by reference when needed;
  • C++: that the students returned lvalue when needed and rvalue when needed etc.
  • C++: When writing an iterator, if it was implemented correctly (a.k.a, according to Input/Output/Forward/Bidirectional/Random Access iterator rules + using iterator traits).
Right now these tests are being done by a human. As our classes formed from 300 to 600 students (next semester we'll have 650...) it'll be really hard and non-efficient to do it by hand. Thus I thought it might be a good idea to automate these checks too.

Initially, I thought to write that with Python using ANTLr (creating an AST for both the Preprocessing stage and the C stage and just iterating over them), but at the middle of programming, I came across the Static Analyser API of Clang and thought I should switch to it, as it seems very mature and well fit for our needs.

Before diving deeply into clang, I'd love to hear from you, who have experience in clang and LLVM dev, if I'm on the right track, and can actually achieve my goal using clang, or I should stick with my previous attempt. Our end goal is a program that we can run, send the path to the student exercise, and get the errors that she had so that we can reduce points accordingly. 

Thank you very much!
Yahav.


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Using clang static analyser / clang-tidy for assignments grading?

Fangrui Song via cfe-dev
In reply to this post by Fangrui Song via cfe-dev

On 29/02/2020 19:11, Yahav Bar via cfe-dev wrote:
> Hi Nathan! How're you?
> Thanks for your kind reply!
>
> I started to dive into Clang and while it does require a learning
> curve, I think that it'll be perfect.
>
>

To learn more, I suggest my blog series here:

  https://devblogs.microsoft.com/cppblog/exploring-clang-tooling-part-1-extending-clang-tidy/

Thanks,

Stephen.

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev