Suggesting https://reviews.llvm.org/rL310905 for 5.0.1 release

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Suggesting https://reviews.llvm.org/rL310905 for 5.0.1 release

Alex Denisov via cfe-dev
Hi Tom,

The mentioned patch fixes miscompilation of llvm/clang when it's
compiled with certain mingw versions. The tablegen tool is miscompiled
and crashes and thus it's not possible to build llvm/clang at all with
some mingw versions.

Please consider to include the patch for 5.0.1.

Best regards,
    Nikolai
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Suggesting https://reviews.llvm.org/rL310905 for 5.0.1 release

Alex Denisov via cfe-dev
On 11/08/2017 01:48 AM, Nikolai Kosjar via cfe-dev wrote:
> Hi Tom,
>
> The mentioned patch fixes miscompilation of llvm/clang when it's compiled with certain mingw versions. The tablegen tool is miscompiled and crashes and thus it's not possible to build llvm/clang at all with some mingw versions.
>
> Please consider to include the patch for 5.0.1.
>

I've created a merge request for this: https://llvm.org/PR35250

-Tom

> Best regards,
>    Nikolai
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Suggesting https://reviews.llvm.org/rL310905 for 5.0.1 release

Alex Denisov via cfe-dev
In reply to this post by Alex Denisov via cfe-dev
If you can reproduce this issue, I would appreciate it if you filed a bug with mingw about it. I made that change by understanding the conditions that caused the bug and avoiding them without reproducing the problem. It's not clear to me what's wrong with requesting an overaligned stack object with __attribute__((align())) in mingw gcc.

On Wed, Nov 8, 2017 at 1:48 AM, Nikolai Kosjar via cfe-dev <[hidden email]> wrote:
Hi Tom,

The mentioned patch fixes miscompilation of llvm/clang when it's compiled with certain mingw versions. The tablegen tool is miscompiled and crashes and thus it's not possible to build llvm/clang at all with some mingw versions.

Please consider to include the patch for 5.0.1.

Best regards,
   Nikolai
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Suggesting https://reviews.llvm.org/rL310905 for 5.0.1 release

Alex Denisov via cfe-dev
I've created a mingw-64 ticket at
https://sourceforge.net/p/mingw-w64/bugs/686/ with everything I know.

Thanks for the workaround Reid! :)

Nikolai


On 11/08/2017 07:27 PM, Reid Kleckner wrote:

> If you can reproduce this issue, I would appreciate it if you filed a
> bug with mingw about it. I made that change by understanding the
> conditions that caused the bug and avoiding them without reproducing the
> problem. It's not clear to me what's wrong with requesting an
> overaligned stack object with __attribute__((align())) in mingw gcc.
>
> On Wed, Nov 8, 2017 at 1:48 AM, Nikolai Kosjar via cfe-dev
> <[hidden email] <mailto:[hidden email]>> wrote:
>
>     Hi Tom,
>
>     The mentioned patch fixes miscompilation of llvm/clang when it's
>     compiled with certain mingw versions. The tablegen tool is
>     miscompiled and crashes and thus it's not possible to build
>     llvm/clang at all with some mingw versions.
>
>     Please consider to include the patch for 5.0.1.
>
>     Best regards,
>         Nikolai
>     _______________________________________________
>     cfe-dev mailing list
>     [hidden email] <mailto:[hidden email]>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>     <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev>
>
>

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev