Submitting a minor clang-format fix

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Submitting a minor clang-format fix

Boris Kolpackov via cfe-dev
Hi,

I’m Erik Uhlmann, an intern at VMware and new to Clang/LLVM. Last week I created a small patch for a minor bug in clang-format (bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665) and submitted to the commit mailing list (as per the LLVM developer policy). I haven’t heard anything back since then. What should I be doing to get my patch accepted? (I’ve attached a new patch against the current svn trunk here.)

Thanks,

Erik Uhlmann


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

Fix-deref-treated-as-binary-op-in-throw.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Submitting a minor clang-format fix

Boris Kolpackov via cfe-dev

Hi Erik,

Submitting patches to the maining list is perfectly fine, but if you haven't already done so you might consider submitting your patch via Phabricator (see: https://reviews.llvm.org)?  I find that approach generally garners more attention.  You can use git blame to see who frequently contributes to clang-format and add them to the patch as a reviewer.  Here's a link for using Phabricator: http://llvm.org/docs/Phabricator.html

The general rule of thumb is to ping a patch about once a week, if you haven't received any feedback.

HTH,
 Chad

On 7/14/2017 4:13 PM, Erik Uhlmann via cfe-dev wrote:
Hi,

I’m Erik Uhlmann, an intern at VMware and new to Clang/LLVM. Last week I created a small patch for a minor bug in clang-format (bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665) and submitted to the commit mailing list (as per the LLVM developer policy). I haven’t heard anything back since then. What should I be doing to get my patch accepted? (I’ve attached a new patch against the current svn trunk here.)

Thanks,

Erik Uhlmann



_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Submitting a minor clang-format fix

Boris Kolpackov via cfe-dev
+1 to the idea of using phab, as it makes reviewing patches (especially small ones) much less work to reviewers.
(I also now hunted down and reviewed the patch, sorry for the long review time)

On Fri, Jul 14, 2017 at 10:23 PM Chad Rosier via cfe-dev <[hidden email]> wrote:

Hi Erik,

Submitting patches to the maining list is perfectly fine, but if you haven't already done so you might consider submitting your patch via Phabricator (see: https://reviews.llvm.org)?  I find that approach generally garners more attention.  You can use git blame to see who frequently contributes to clang-format and add them to the patch as a reviewer.  Here's a link for using Phabricator: http://llvm.org/docs/Phabricator.html

The general rule of thumb is to ping a patch about once a week, if you haven't received any feedback.

HTH,
 Chad


On 7/14/2017 4:13 PM, Erik Uhlmann via cfe-dev wrote:
Hi,

I’m Erik Uhlmann, an intern at VMware and new to Clang/LLVM. Last week I created a small patch for a minor bug in clang-format (bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665) and submitted to the commit mailing list (as per the LLVM developer policy). I haven’t heard anything back since then. What should I be doing to get my patch accepted? (I’ve attached a new patch against the current svn trunk here.)

Thanks,

Erik Uhlmann



_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev