Reusing code from an accepted patch

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Reusing code from an accepted patch

Don Hinton via cfe-dev
Hello,

Some time ago I've posted a patch and it has been accepted: https://reviews.llvm.org/D50766.
It fixes one of C++17's unsequenced warnings. Now, I finally have some time to work on the rest of p0145's warnings (and a couple more). To work on a new patch, I'd like to reuse function that has been implemented in the D50766. How can I achieve that, without just copying it into the new patch?

I mean, the main question is: what's the status of D50766? I can see that it has been accepted on
Phabricator, but I can't find its code on the master branch.

Thanks in advance,
Mateusz Janek

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Reusing code from an accepted patch

Don Hinton via cfe-dev

In the LLVM project process, "accepting" a patch means the reviewers have approved it. However, it is still up to you, the patch author, to commit it into the project sources. We don't have an automated pull-request kind of process.

--paulr

 

From: cfe-dev [mailto:[hidden email]] On Behalf Of mateusz janek via cfe-dev
Sent: Thursday, January 10, 2019 10:08 AM
To: Clang Dev
Subject: [cfe-dev] Reusing code from an accepted patch

 

Hello,

 

Some time ago I've posted a patch and it has been accepted: https://reviews.llvm.org/D50766.

It fixes one of C++17's unsequenced warnings. Now, I finally have some time to work on the rest of p0145's warnings (and a couple more). To work on a new patch, I'd like to reuse function that has been implemented in the D50766. How can I achieve that, without just copying it into the new patch?

 

I mean, the main question is: what's the status of D50766? I can see that it has been accepted on

Phabricator, but I can't find its code on the master branch.

 

Thanks in advance,

Mateusz Janek


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Reusing code from an accepted patch

Don Hinton via cfe-dev
If you don't have commit rights
(https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access),
you can ask someone, typically your reviewers, to commit it for you.

Michael


Am Do., 10. Jan. 2019 um 09:12 Uhr schrieb via cfe-dev <[hidden email]>:

>
> In the LLVM project process, "accepting" a patch means the reviewers have approved it. However, it is still up to you, the patch author, to commit it into the project sources. We don't have an automated pull-request kind of process.
>
> --paulr
>
>
>
> From: cfe-dev [mailto:[hidden email]] On Behalf Of mateusz janek via cfe-dev
> Sent: Thursday, January 10, 2019 10:08 AM
> To: Clang Dev
> Subject: [cfe-dev] Reusing code from an accepted patch
>
>
>
> Hello,
>
>
>
> Some time ago I've posted a patch and it has been accepted: https://reviews.llvm.org/D50766.
>
> It fixes one of C++17's unsequenced warnings. Now, I finally have some time to work on the rest of p0145's warnings (and a couple more). To work on a new patch, I'd like to reuse function that has been implemented in the D50766. How can I achieve that, without just copying it into the new patch?
>
>
>
> I mean, the main question is: what's the status of D50766? I can see that it has been accepted on
>
> Phabricator, but I can't find its code on the master branch.
>
>
>
> Thanks in advance,
>
> Mateusz Janek
>
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Reusing code from an accepted patch

Don Hinton via cfe-dev
Thank you for help. It's all clear now.

Best regards,
Mateusz

czw., 10 sty 2019 o 16:36 Michael Kruse <[hidden email]> napisał(a):
If you don't have commit rights
(https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access),
you can ask someone, typically your reviewers, to commit it for you.

Michael


Am Do., 10. Jan. 2019 um 09:12 Uhr schrieb via cfe-dev <[hidden email]>:
>
> In the LLVM project process, "accepting" a patch means the reviewers have approved it. However, it is still up to you, the patch author, to commit it into the project sources. We don't have an automated pull-request kind of process.
>
> --paulr
>
>
>
> From: cfe-dev [mailto:[hidden email]] On Behalf Of mateusz janek via cfe-dev
> Sent: Thursday, January 10, 2019 10:08 AM
> To: Clang Dev
> Subject: [cfe-dev] Reusing code from an accepted patch
>
>
>
> Hello,
>
>
>
> Some time ago I've posted a patch and it has been accepted: https://reviews.llvm.org/D50766.
>
> It fixes one of C++17's unsequenced warnings. Now, I finally have some time to work on the rest of p0145's warnings (and a couple more). To work on a new patch, I'd like to reuse function that has been implemented in the D50766. How can I achieve that, without just copying it into the new patch?
>
>
>
> I mean, the main question is: what's the status of D50766? I can see that it has been accepted on
>
> Phabricator, but I can't find its code on the master branch.
>
>
>
> Thanks in advance,
>
> Mateusz Janek
>
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev