Patch: wchar_t support

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch: wchar_t support

Nico Weber
Hi,

the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.

The patch also makes one of lits error messages less confusing.

Nico

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

wchar-objc.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch: wchar_t support

John McCall
On Jun 10, 2010, at 9:46 PM, Nico Weber wrote:
> the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.

I committed this part, thanks!

> The patch also makes one of lits error messages less confusing.

I didn't commit this part;  it looks reasonable to me, but Daniel should weigh in.

John.
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch: wchar_t support

Nico Weber
In reply to this post by Nico Weber
Looks like John landed this in r105818. Thanks!

On Thu, Jun 10, 2010 at 9:46 PM, Nico Weber <[hidden email]> wrote:
Hi,

the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.

The patch also makes one of lits error messages less confusing.

Nico


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch: wchar_t support

Nico Weber
In reply to this post by Nico Weber
Looks like John landed this in r105818. Thanks!

On Thu, Jun 10, 2010 at 9:46 PM, Nico Weber <[hidden email]> wrote:
Hi,

the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.

The patch also makes one of lits error messages less confusing.

Nico


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch: wchar_t support

Nico Weber
In reply to this post by John McCall
On Fri, Jun 11, 2010 at 3:12 AM, John McCall <[hidden email]> wrote:
> On Jun 10, 2010, at 9:46 PM, Nico Weber wrote:
>> the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.
>
> I committed this part, thanks!
>
>> The patch also makes one of lits error messages less confusing.
>
> I didn't commit this part;  it looks reasonable to me, but Daniel should weigh in.

Daniel, what do you think of the lit patch? Would've saved me some 5
minutes back then.

>
> John.

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch: wchar_t support

Daniel Dunbar-3

On Jun 30, 2010, at 4:03 PM, Nico Weber wrote:

> On Fri, Jun 11, 2010 at 3:12 AM, John McCall <[hidden email]> wrote:
>> On Jun 10, 2010, at 9:46 PM, Nico Weber wrote:
>>> the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.
>>
>> I committed this part, thanks!
>>
>>> The patch also makes one of lits error messages less confusing.
>>
>> I didn't commit this part;  it looks reasonable to me, but Daniel should weigh in.
>
> Daniel, what do you think of the lit patch? Would've saved me some 5
> minutes back then.

Sure, looks fine. I would phrase it:
        lit.fatal('No site specific configuration available! You may need to run 'make test' in your Clang build directory.')

 - Daniel

>
>>
>> John.


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev