Patch: Add support for &@selector()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch: Add support for &@selector()

Nico Weber
Hi,

the attached patch might fix PR7390.

Random trivia: GCC happily compiles `SEL a; @selector(foo) = a;`.

Nico

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

clang-addrofsel-3.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch: Add support for &@selector()

Nico Weber
the attached patch might fix PR7390.

Random trivia: GCC happily compiles `SEL a; @selector(foo) = a;`.

Fariborz, I saw that you just committed http://llvm.org/viewvc/llvm-project?view=rev&revision=106235 for the bug. With your patch, clang now treats @selectors() as lvalues and compiles `SEL a; @selector(foo) = a;` without complaint. I think that's wrong.

Nico

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch: Add support for &@selector()

jahanian

On Jun 17, 2010, at 1:54 PM, Nico Weber wrote:

the attached patch might fix PR7390.

Random trivia: GCC happily compiles `SEL a; @selector(foo) = a;`.

Fariborz, I saw that you just committed http://llvm.org/viewvc/llvm-project?view=rev&revision=106235 for the bug. With your patch, clang now treats @selectors() as lvalues and compiles `SEL a; @selector(foo) = a;` without complaint. I think that's wrong.

Sorry, our patches crossed path. I will take a look at this regression.

- Fariborz


Nico


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev