[PATCH] and getting started

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] and getting started

dawn

I'd like to a submit the attached simple patch for review to get
familiar with the clang commit process.  The instructions at
http://llvm.org/docs/DeveloperPolicy.html say "When sending a patch to
a mailing list" but don't actually come out and say that one should
start by submitting a patch to this mailing list :-).  Please correct me
(and the web site) if I got it wrong.

Thanks!
-Dawn

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

clang.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] and getting started

dawn
PS: corrected patch attached

On Wed, Aug 25, 2010 at 11:53:22AM -0700, [hidden email] wrote:

>
> I'd like to a submit the attached simple patch for review to get
> familiar with the clang commit process.  The instructions at
> http://llvm.org/docs/DeveloperPolicy.html say "When sending a patch to
> a mailing list" but don't actually come out and say that one should
> start by submitting a patch to this mailing list :-).  Please correct me
> (and the web site) if I got it wrong.
>
> Thanks!
> -Dawn

> Index: lib/Sema/SemaOverload.cpp
> ===================================================================
> --- lib/Sema/SemaOverload.cpp (revision 110949)
> +++ lib/Sema/SemaOverload.cpp (working copy)
> @@ -2119,6 +2119,7 @@
>    return ImplicitConversionSequence::Indistinguishable;
>  }
>  
> +int die() { /*printf("hi\n");*/ return 0; } //DAWN
>  static bool hasSimilarType(ASTContext &Context, QualType T1, QualType T2) {
>    while (Context.UnwrapSimilarPointerTypes(T1, T2)) {
>      Qualifiers Quals;
> Index: lib/Lex/Preprocessor.cpp
> ===================================================================
> --- lib/Lex/Preprocessor.cpp (revision 112066)
> +++ lib/Lex/Preprocessor.cpp (working copy)
> @@ -531,7 +531,7 @@
>    // Preprocess Predefines to populate the initial preprocessor state.
>    llvm::MemoryBuffer *SB =
>      llvm::MemoryBuffer::getMemBufferCopy(Predefines, "<built-in>");
> -  assert(SB && "Cannot fail to create predefined source buffer");
> +  assert(SB && "Cannot create predefined source buffer");
>    FileID FID = SourceMgr.createFileIDForMemBuffer(SB);
>    assert(!FID.isInvalid() && "Could not create FileID for predefines?");
>  

> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

clang.patch (651 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] and getting started

Douglas Gregor
In reply to this post by dawn

On Aug 25, 2010, at 11:53 AM, [hidden email] wrote:

>
> I'd like to a submit the attached simple patch for review to get
> familiar with the clang commit process.  The instructions at
> http://llvm.org/docs/DeveloperPolicy.html say "When sending a patch to
> a mailing list" but don't actually come out and say that one should
> start by submitting a patch to this mailing list :-).  Please correct me
> (and the web site) if I got it wrong.


Generally, patches should go to cfe-commits. This list is usually used to general discussions, questions, etc. Otherwise, patch looks good! I committed the assertion text change in r112182.

        - Doug
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev