[PATCH] Default implementation for ExternalASTSource's pure virtual functions

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Default implementation for ExternalASTSource's pure virtual functions

Axel Naumann
Hi,

I'd suggest to provide default implementations for ExternalASTSource's
pure virtual functions. Derived classes should actually not be required
to implement them. See e.g. r126387 (offering an orthogonal lookup
source through ExternalASTSource::LookupUnqualified()), and lldb.

Attached patch does that (+ cleanup of forward declarations).

I think it's a semi-minor patch, so if there are no comments I'll commit
it in 24 hours :-)

Cheers, Axel.

_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

ExternalASTSource_default_impl.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Default implementation for ExternalASTSource's pure virtual functions

Douglas Gregor


Sent from my iPhone

On Feb 24, 2011, at 9:37 AM, Axel Naumann <[hidden email]> wrote:

> Hi,
>
> I'd suggest to provide default implementations for ExternalASTSource's
> pure virtual functions. Derived classes should actually not be required
> to implement them. See e.g. r126387 (offering an orthogonal lookup
> source through ExternalASTSource::LookupUnqualified()), and lldb.

Please put these definitions into a .cpp file. They'll never be inlined anyway.

> Attached patch does that (+ cleanup of forward declarations).
>
> I think it's a semi-minor patch, so if there are no comments I'll commit
> it in 24 hours :-)
>
> Cheers, Axel.
> <ExternalASTSource_default_impl.diff>
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev