Instructions for requesting GitHub commit access

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Instructions for requesting GitHub commit access

Kristóf Umann via cfe-dev
Hi,

I've created a text file[1] in the SVN repository that developers can
update in order to request commit access to the GitHub repository.
All you need to do is add a line in the form of
$SVN_USERNAME:$GITHUB_USERNAME

Please add your information to this file before SVN becomes readonly
on October 21 to avoid a gap in commit access.  More details can be found in
the phabriactor review[2] that updates the developer policy.

We will be verifying that the svn committer matches the username in the
file, so you can only request access for yourself and not someone else

Thanks,
Tom

[1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-usernames.txt?view=markup
[2] https://reviews.llvm.org/D66840
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openmp-dev] Instructions for requesting GitHub commit access

Kristóf Umann via cfe-dev
What is the expected way to do commits?  Do we push directly to master
after a rebase?  I know there has been talk of using GitHub pull
requests and I would be in favor of that.  What's the status of those
discussions?

                       -David

Tom Stellard via Openmp-dev <[hidden email]> writes:

> Hi,
>
> I've created a text file[1] in the SVN repository that developers can
> update in order to request commit access to the GitHub repository.
> All you need to do is add a line in the form of
> $SVN_USERNAME:$GITHUB_USERNAME
>
> Please add your information to this file before SVN becomes readonly
> on October 21 to avoid a gap in commit access.  More details can be found in
> the phabriactor review[2] that updates the developer policy.
>
> We will be verifying that the svn committer matches the username in the
> file, so you can only request access for yourself and not someone else
>
> Thanks,
> Tom
>
> [1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-usernames.txt?view=markup
> [2] https://reviews.llvm.org/D66840
> _______________________________________________
> Openmp-dev mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openmp-dev] Instructions for requesting GitHub commit access

Kristóf Umann via cfe-dev
One is expected to use `git llvm push`. For more information, please see:

https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git


> On Sep 3, 2019, at 7:06 PM, David Greene via cfe-dev <[hidden email]> wrote:
>
> What is the expected way to do commits?  Do we push directly to master
> after a rebase?  I know there has been talk of using GitHub pull
> requests and I would be in favor of that.  What's the status of those
> discussions?
>
>                       -David
>
> Tom Stellard via Openmp-dev <[hidden email]> writes:
>
>> Hi,
>>
>> I've created a text file[1] in the SVN repository that developers can
>> update in order to request commit access to the GitHub repository.
>> All you need to do is add a line in the form of
>> $SVN_USERNAME:$GITHUB_USERNAME
>>
>> Please add your information to this file before SVN becomes readonly
>> on October 21 to avoid a gap in commit access.  More details can be found in
>> the phabriactor review[2] that updates the developer policy.
>>
>> We will be verifying that the svn committer matches the username in the
>> file, so you can only request access for yourself and not someone else
>>
>> Thanks,
>> Tom
>>
>> [1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-usernames.txt?view=markup
>> [2] https://reviews.llvm.org/D66840
>> _______________________________________________
>> Openmp-dev mailing list
>> [hidden email]
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] [Openmp-dev] Instructions for requesting GitHub commit access

Kristóf Umann via cfe-dev


> -----Original Message-----
> From: llvm-dev [mailto:[hidden email]] On Behalf Of David
> Zarzycki via llvm-dev
> Sent: Wednesday, September 04, 2019 8:07 AM
> To: David Greene
> Cc: llvm-dev; LLDB Dev; cfe-dev; openmp-dev ([hidden email])
> Subject: Re: [llvm-dev] [cfe-dev] [Openmp-dev] Instructions for requesting
> GitHub commit access
>
> One is expected to use `git llvm push`. For more information, please see:
>
> https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-
> changes-from-git

FTR, that page is written to describe the current situation (with the
git-to-svn loop behind the scenes), and doesn't say anything about what
happens after the changeover.

https://bugs.llvm.org/show_bug.cgi?id=42430 does suggest that we will
keep using `git llvm push` after the changeover, and it will just do
different things (like guaranteeing no merge commits get pushed).
--paulr

>
>
> > On Sep 3, 2019, at 7:06 PM, David Greene via cfe-dev <cfe-
> [hidden email]> wrote:
> >
> > What is the expected way to do commits?  Do we push directly to master
> > after a rebase?  I know there has been talk of using GitHub pull
> > requests and I would be in favor of that.  What's the status of those
> > discussions?
> >
> >                       -David
> >
> > Tom Stellard via Openmp-dev <[hidden email]> writes:
> >
> >> Hi,
> >>
> >> I've created a text file[1] in the SVN repository that developers can
> >> update in order to request commit access to the GitHub repository.
> >> All you need to do is add a line in the form of
> >> $SVN_USERNAME:$GITHUB_USERNAME
> >>
> >> Please add your information to this file before SVN becomes readonly
> >> on October 21 to avoid a gap in commit access.  More details can be
> found in
> >> the phabriactor review[2] that updates the developer policy.
> >>
> >> We will be verifying that the svn committer matches the username in the
> >> file, so you can only request access for yourself and not someone else
> >>
> >> Thanks,
> >> Tom
> >>
> >> [1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-
> usernames.txt?view=markup
> >> [2] https://reviews.llvm.org/D66840
> >> _______________________________________________
> >> Openmp-dev mailing list
> >> [hidden email]
> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> > _______________________________________________
> > cfe-dev mailing list
> > [hidden email]
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openmp-dev] [llvm-dev] Instructions for requesting GitHub commit access

Kristóf Umann via cfe-dev
On 09/04/2019 07:19 AM, via Openmp-dev wrote:

>
>
>> -----Original Message-----
>> From: llvm-dev [mailto:[hidden email]] On Behalf Of David
>> Zarzycki via llvm-dev
>> Sent: Wednesday, September 04, 2019 8:07 AM
>> To: David Greene
>> Cc: llvm-dev; LLDB Dev; cfe-dev; openmp-dev ([hidden email])
>> Subject: Re: [llvm-dev] [cfe-dev] [Openmp-dev] Instructions for requesting
>> GitHub commit access
>>
>> One is expected to use `git llvm push`. For more information, please see:
>>
>> https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-
>> changes-from-git
>
> FTR, that page is written to describe the current situation (with the
> git-to-svn loop behind the scenes), and doesn't say anything about what
> happens after the changeover.
>
> https://bugs.llvm.org/show_bug.cgi?id=42430 does suggest that we will
> keep using `git llvm push` after the changeover, and it will just do
> different things (like guaranteeing no merge commits get pushed).
> --paulr
>

This is correct, we will continue to use `git llvm push` after transitioning
to GitHub.

-Tom

>>
>>
>>> On Sep 3, 2019, at 7:06 PM, David Greene via cfe-dev <cfe-
>> [hidden email]> wrote:
>>>
>>> What is the expected way to do commits?  Do we push directly to master
>>> after a rebase?  I know there has been talk of using GitHub pull
>>> requests and I would be in favor of that.  What's the status of those
>>> discussions?
>>>
>>>                       -David
>>>
>>> Tom Stellard via Openmp-dev <[hidden email]> writes:
>>>
>>>> Hi,
>>>>
>>>> I've created a text file[1] in the SVN repository that developers can
>>>> update in order to request commit access to the GitHub repository.
>>>> All you need to do is add a line in the form of
>>>> $SVN_USERNAME:$GITHUB_USERNAME
>>>>
>>>> Please add your information to this file before SVN becomes readonly
>>>> on October 21 to avoid a gap in commit access.  More details can be
>> found in
>>>> the phabriactor review[2] that updates the developer policy.
>>>>
>>>> We will be verifying that the svn committer matches the username in the
>>>> file, so you can only request access for yourself and not someone else
>>>>
>>>> Thanks,
>>>> Tom
>>>>
>>>> [1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-
>> usernames.txt?view=markup
>>>> [2] https://reviews.llvm.org/D66840
>>>> _______________________________________________
>>>> Openmp-dev mailing list
>>>> [hidden email]
>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
>>> _______________________________________________
>>> cfe-dev mailing list
>>> [hidden email]
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> _______________________________________________
> Openmp-dev mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
>

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev