Duty after a revision is accepted

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Duty after a revision is accepted

shirley breuer via cfe-dev
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Duty after a revision is accepted

shirley breuer via cfe-dev
You could ask one of the reviewers to submit on your behalf or send an email to the list (just like you have).

Have a great weekend!

Jon

> On 12 Feb 2021, at 18:58, Deep Majumder via cfe-dev <[hidden email]> wrote:
>
> 
> Hi everyone,
> Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
> Warm regards,
> Deep
> _______________________________________________
> cfe-dev mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
In reply to this post by shirley breuer via cfe-dev
On Sat, Feb 13, 2021 at 12:28:42AM +0530, Deep Majumder via llvm-dev wrote:
> Hi everyone,
> Sorry for the trivial question, but after a revision is accepted, do I have
> to do anything as the revision author? I do not have commit rights btw (and
> so the revision is accepted by someone else who does have).

Just tell whoever accepted it.

Joerg
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
In reply to this post by shirley breuer via cfe-dev

As others have said, ask one of your reviewers to land it for you.

For context, as a community we generally assume authors have commit access unless they explicitly say otherwise.  Unlike some other open source projects, LLVM distributes commit rights widely, so it's common for most authors to have commit rights even if they contribute very rarely.  As a result, reviewers are unlikely to release an author doesn't have commit rights on their own. 

Philip

On 2/12/21 10:58 AM, Deep Majumder via llvm-dev wrote:
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
Hi Philip,
How do I get commit access in that case?
Warm regards,
Deep

On Sat, Feb 13, 2021, 3:49 AM Philip Reames <[hidden email]> wrote:

As others have said, ask one of your reviewers to land it for you.

For context, as a community we generally assume authors have commit access unless they explicitly say otherwise.  Unlike some other open source projects, LLVM distributes commit rights widely, so it's common for most authors to have commit rights even if they contribute very rarely.  As a result, reviewers are unlikely to release an author doesn't have commit rights on their own. 

Philip

On 2/12/21 10:58 AM, Deep Majumder via llvm-dev wrote:
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
After enough revisions I was invited to apply for committee access.

Not sure if there’s a more formal process in place now.

J

On 13 Feb 2021, at 14:01, Deep Majumder via cfe-dev <[hidden email]> wrote:


Hi Philip,
How do I get commit access in that case?
Warm regards,
Deep

On Sat, Feb 13, 2021, 3:49 AM Philip Reames <[hidden email]> wrote:

As others have said, ask one of your reviewers to land it for you.

For context, as a community we generally assume authors have commit access unless they explicitly say otherwise.  Unlike some other open source projects, LLVM distributes commit rights widely, so it's common for most authors to have commit rights even if they contribute very rarely.  As a result, reviewers are unlikely to release an author doesn't have commit rights on their own. 

Philip

On 2/12/21 10:58 AM, Deep Majumder via llvm-dev wrote:
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
In reply to this post by shirley breuer via cfe-dev

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

On 2/13/21 6:01 AM, Deep Majumder wrote:
Hi Philip,
How do I get commit access in that case?
Warm regards,
Deep

On Sat, Feb 13, 2021, 3:49 AM Philip Reames <[hidden email]> wrote:

As others have said, ask one of your reviewers to land it for you.

For context, as a community we generally assume authors have commit access unless they explicitly say otherwise.  Unlike some other open source projects, LLVM distributes commit rights widely, so it's common for most authors to have commit rights even if they contribute very rarely.  As a result, reviewers are unlikely to release an author doesn't have commit rights on their own. 

Philip

On 2/12/21 10:58 AM, Deep Majumder via llvm-dev wrote:
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Duty after a revision is accepted

shirley breuer via cfe-dev
Thanks Philip! I couldn't find this page on Google for some reason.

On Sat, Feb 13, 2021, 10:59 PM Philip Reames <[hidden email]> wrote:

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

On 2/13/21 6:01 AM, Deep Majumder wrote:
Hi Philip,
How do I get commit access in that case?
Warm regards,
Deep

On Sat, Feb 13, 2021, 3:49 AM Philip Reames <[hidden email]> wrote:

As others have said, ask one of your reviewers to land it for you.

For context, as a community we generally assume authors have commit access unless they explicitly say otherwise.  Unlike some other open source projects, LLVM distributes commit rights widely, so it's common for most authors to have commit rights even if they contribute very rarely.  As a result, reviewers are unlikely to release an author doesn't have commit rights on their own. 

Philip

On 2/12/21 10:58 AM, Deep Majumder via llvm-dev wrote:
Hi everyone,
Sorry for the trivial question, but after a revision is accepted, do I have to do anything as the revision author? I do not have commit rights btw (and so the revision is accepted by someone else who does have).
Warm regards,
Deep

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev