Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Hubert Tong via cfe-dev
Hello Team,
Please review changes:  https://reviews.llvm.org/D83929

Problem: Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.

Solution: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).

Regards,
Nadaf.

_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Hubert Tong via cfe-dev
I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.

-Min

On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <[hidden email]> wrote:

Hello Team,
Please review changes:  https://reviews.llvm.org/D83929

Problem: Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.

Solution: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).

Regards,
Nadaf.
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Hubert Tong via cfe-dev
Hello Min-Yih,
Yes, I added clang-c group as reviewers

Regards,
Nadaf.

On Wed, Jul 22, 2020 at 3:39 PM Min-Yih Hsu <[hidden email]> wrote:
I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.

-Min

On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <[hidden email]> wrote:

Hello Team,
Please review changes:  https://reviews.llvm.org/D83929

Problem: Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.

Solution: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).

Regards,
Nadaf.
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Hubert Tong via cfe-dev
Hello Team,
Reminder!.
Please review changes  https://reviews.llvm.org/D83929

Regards,
Nadaf.  

On Wed, Jul 22, 2020 at 3:48 PM Gousemoodhin Nadaf <[hidden email]> wrote:
Hello Min-Yih,
Yes, I added clang-c group as reviewers

Regards,
Nadaf.

On Wed, Jul 22, 2020 at 3:39 PM Min-Yih Hsu <[hidden email]> wrote:
I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.

-Min

On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <[hidden email]> wrote:

Hello Team,
Please review changes:  https://reviews.llvm.org/D83929

Problem: Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.

Solution: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).

Regards,
Nadaf.
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Hubert Tong via cfe-dev
Hello Team,
Reworked on comments, please review  https://reviews.llvm.org/D83929

Regards,
Nadaf

On Wed, Jul 29, 2020 at 5:02 PM Gousemoodhin Nadaf <[hidden email]> wrote:
Hello Team,
Reminder!.
Please review changes  https://reviews.llvm.org/D83929

Regards,
Nadaf.  

On Wed, Jul 22, 2020 at 3:48 PM Gousemoodhin Nadaf <[hidden email]> wrote:
Hello Min-Yih,
Yes, I added clang-c group as reviewers

Regards,
Nadaf.

On Wed, Jul 22, 2020 at 3:39 PM Min-Yih Hsu <[hidden email]> wrote:
I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.

-Min

On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <[hidden email]> wrote:

Hello Team,
Please review changes:  https://reviews.llvm.org/D83929

Problem: Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.

Solution: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).

Regards,
Nadaf.
_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


_______________________________________________
cfe-dev mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev